fix: image-to-gcode.py for modern numpy/tkinter#4021
Merged
andypugh merged 1 commit intoMay 24, 2026
Merged
Conversation
- Numpy renamed `numpy.core.Inf` -> `numpy.core.inf`.
- However, `numpy.core` was also deprecated and renamed, hence it
would be `numpy._core.inf`.
- But really, `numpy.inf` does work too.
- Avoid closing the `tkinter._default_root`, it's not necessary anymore
(probably since python/cpython#23897).
Nowadays, there isn't even a `tkinter._default_root` per default.
Signed-off-by: wucke13 <wucke13+github@gmail.com>
wucke13
force-pushed
the
dev/wucke13/fix-image-to-gcode-for-modern-numpy-and-tk
branch
from
72d9ba2 to
f80e312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy.core.Inf->numpy.core.inf.numpy.corewas also deprecated and renamed, hence it would benumpy._core.inf.numpy.infdoes work too._default_root, it's not necessary anymore (probably since bpo-42721: Improve using simple dialogs without root window python/cpython#23897). Nowadays, there isn't even atkinter._default_rootper default.